devmadhuu commented on code in PR #11229:
URL: https://github.com/apache/ozone/pull/11229#discussion_r4081858572
##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/util/S3Consts.java:
##########
@@ -131,6 +131,11 @@ public final class S3Consts {
/** Request header carrying the list of object attributes to return. */
public static final String OBJECT_ATTRIBUTES_HEADER =
"x-amz-object-attributes";
+ // S3 storage class values passed via the `x-amz-storage-class` request
header.
+ public static final String S3_STORAGE_CLASS_STANDARD = "STANDARD";
+ public static final String S3_STORAGE_CLASS_STANDARD_IA = "STANDARD_IA";
+ public static final String S3_STORAGE_CLASS_GLACIER = "GLACIER";
+
Review Comment:
@xichen01 so what is the way to go forward ? should we combine both and
adapt the concept of durability, SLA, zones, and latency , etc as below in
existing `S3StorageType`
Add a second constructor arg. `GLACIER` gets null replication, meaning "no
replication opinion,
archive tier only" — AWS does not
pin storage class to a replica count,
and inventing one for `GLACIER` would make it indistinguishable from
STANDARD_IA on the reverse map.
```
REDUCED_REDUNDANCY(RatisReplicationConfig.getInstance(ReplicationFactor.ONE),
HOT),
STANDARD(RatisReplicationConfig.getInstance(ReplicationFactor.THREE),
HOT),
STANDARD_IA(new ECReplicationConfig(3, 2),
WARM),
GLACIER(null,
COLD);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
