adoroszlai opened a new pull request, #11308:
URL: https://github.com/apache/ozone/pull/11308
## What changes were proposed in this pull request?
Improve `errorprone` check:
1. Save time by skipping `ozone-filesystem-shaded`
- CI: `ozone-filesystem-shaded` is picked up from `build` check's results
- local run: also skip dependent modules (`ozone-filesystem-hadoop[23]`)
2. Turn off Maven timestamp prefix (can configured by
`-Dorg.slf4j.simpleLogger.showDateTime=true`), because patterns in
`errorprone.sh` look for `[ERROR]`/`[WARNING]` at line start
3. Turn off Develocity local cache, because the check needs the side-effect
of compilation (i.e. compiler warnings/errors), which is omitted when results
come from cache.
https://issues.apache.org/jira/browse/HDDS-16582
## How was this patch tested?
Tested locally:
```
$ ./hadoop-ozone/dev-support/checks/errorprone.sh
...
[INFO] BUILD SUCCESS
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 05:24 min
[INFO]
------------------------------------------------------------------------
[INFO] 958 goals, 958 executed
```
Verified that ErrorProne still
[checks](https://github.com/adoroszlai/ozone/actions/runs/35825940140/job/107070771165#step:13:12032)
`ozone-filesystem-hadoop2` and `ozone-filesystem-hadoop3` in CI:
```
[INFO] --- compiler:3.16.0:compile (default-compile) @
ozone-filesystem-hadoop2 ---
[INFO] Compiling 7 source files with javac [forked debug release 8] to
target/classes
[WARNING] [options] source value 8 is obsolete and will be removed in a
future release
[WARNING] [options] target value 8 is obsolete and will be removed in a
future release
[WARNING] [options] To suppress warnings about obsolete options, use
-Xlint:-options.
[WARNING]
/home/runner/work/ozone/ozone/hadoop-ozone/ozonefs-hadoop2/target/generated-sources/java/org/apache/hadoop/fs/ozone/OzFs.java:[52,18]
[Finalize] Do not override finalize
(see https://errorprone.info/bugpattern/Finalize)
[WARNING]
/home/runner/work/ozone/ozone/hadoop-ozone/ozonefs-hadoop2/target/generated-sources/java/org/apache/hadoop/fs/ozone/RootedOzFs.java:[52,18]
[Finalize] Do not override finalize
(see https://errorprone.info/bugpattern/Finalize)
...
[INFO] --- compiler:3.16.0:compile (default-compile) @
ozone-filesystem-hadoop3 ---
[INFO] Compiling 5 source files with javac [forked debug release 8] to
target/classes
[WARNING] [options] source value 8 is obsolete and will be removed in a
future release
[WARNING] [options] target value 8 is obsolete and will be removed in a
future release
[WARNING] [options] To suppress warnings about obsolete options, use
-Xlint:-options.
[WARNING]
/home/runner/work/ozone/ozone/hadoop-ozone/ozonefs-hadoop3/src/main/java/org/apache/hadoop/fs/ozone/OzFs.java:[47,18]
[Finalize] Do not override finalize
(see https://errorprone.info/bugpattern/Finalize)
[WARNING]
/home/runner/work/ozone/ozone/hadoop-ozone/ozonefs-hadoop3/src/main/java/org/apache/hadoop/fs/ozone/OzoneFileSystem.java:[137,14]
[AlreadyChecked] This condition (on cap) is already known to be true; it (or
its complement) has already been checked.
(see https://errorprone.info/bugpattern/AlreadyChecked)
[WARNING]
/home/runner/work/ozone/ozone/hadoop-ozone/ozonefs-hadoop3/src/main/java/org/apache/hadoop/fs/ozone/RootedOzFs.java:[47,18]
[Finalize] Do not override finalize
(see https://errorprone.info/bugpattern/Finalize)
[WARNING]
/home/runner/work/ozone/ozone/hadoop-ozone/ozonefs-hadoop3/src/main/java/org/apache/hadoop/fs/ozone/RootedOzoneFileSystem.java:[135,14]
[AlreadyChecked] This condition (on cap) is already known to be true; it (or
its complement) has already been checked.
(see https://errorprone.info/bugpattern/AlreadyChecked)
```
`errorprone` time in CI is reduced
[from](https://github.com/apache/ozone/actions/runs/35824450076/job/107063138064)
14 minutes
[to](https://github.com/adoroszlai/ozone/actions/runs/35825940140/job/107070771165)
11.5 minutes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
