jojochuang commented on PR #11118: URL: https://github.com/apache/ozone/pull/11118#issuecomment-5747541921
My coding agent also flag a potential issue but that was already the case prior to this PR: that KeyInfo could be stale by the time it is deleted and quota may be calculated incorrect. Instead, it should read from db instead of trusting the key size from the KeyInfo replica in the ratis transaction request. That could happen when a hsync is called, or when we introduce appen() file system semantics which updates file size. For now, that shouldn't be a concern. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
