rich7420 commented on code in PR #11242:
URL: https://github.com/apache/ozone/pull/11242#discussion_r4038173782


##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/ObjectAttributesHandler.java:
##########
@@ -204,8 +214,10 @@ private GetObjectAttributesResponse buildResponse(String 
keyPath, OzoneKey key,
       if (eTag != null) {
         String partsCountStr = extractPartsCount(eTag);
         if (partsCountStr != null && completedPartSizes != null) {
+          boolean directoryBucketLayout =
+              context.getBucket().getBucketLayout().isFileSystemOptimized();

Review Comment:
   This can make multipart `ObjectParts` requests fail with `AccessDenied`, 
including OBS: the new lookup [requires bucket 
READ](https://github.com/apache/ozone/blob/a8268400d8d2ab9850dd1b6dfe4d8df4fb7b61f0/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java#L3251-L3254).
 Ranger users may have volume/key READ without bucket READ. Could we preserve 
the existing permission requirements and add a regression test?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to