chihsuan commented on code in PR #11250:
URL: https://github.com/apache/ozone/pull/11250#discussion_r4036894469
##########
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/keyvalue/TestKeyValueHandler.java:
##########
@@ -1200,64 +1198,128 @@ private void assertOutOfRange(ReadBlockResult result,
long offset) {
.contains(String.valueOf(BLOCK_SIZE));
}
+ /** A request rejected on the stream ends the call from the datanode side,
so the block file must be closed there. */
+ @Test
+ public void testReadBlockErrorOnTheStreamClosesTheBlockFile() throws
Exception {
Review Comment:
nit: Would it be worth adding a successful read before the out-of-range
request? It helps confirm that an already-open file is being closed on the same
stream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
