adoroszlai commented on code in PR #11247:
URL: https://github.com/apache/ozone/pull/11247#discussion_r4035071964
##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientRatis.java:
##########
@@ -399,12 +411,11 @@ public XceiverClientReply sendCommandAsync(
ContainerCommandResponseProto response =
ContainerCommandResponseProto
.parseFrom(reply.getMessage().getContent());
- UUID serverId = RatisHelper.toDatanodeId(reply.getReplierId());
if (response.getResult() == ContainerProtos.Result.SUCCESS) {
updateCommitInfosMap(reply.getCommitInfos(), watchType);
}
asyncReply.setLogIndex(reply.getLogIndex());
- addDatanodetoReply(serverId, asyncReply);
+ addDatanodetoReply(reply.getReplierId(), asyncReply);
Review Comment:
The reply's list of datanodes is used only for watchForCommit commands, to
mark failed nodes:
https://github.com/apache/ozone/blob/7f33fc535acf5f6861a1d70a24913253ca8d6e46/hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/BlockOutputStream.java#L542-L553
and
https://github.com/apache/ozone/blob/7f33fc535acf5f6861a1d70a24913253ca8d6e46/hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/BlockDataStreamOutput.java#L383-L393
But here the node is added for all kinds of commands and regardless of its
result.
Question: is it even necessary to add the datanode here? (I tried [removing
it](https://github.com/adoroszlai/ozone/commit/cde6e72f5edc6b9107f9bf5a7b94e2fa0df3c771)
and CI [passed](https://github.com/adoroszlai/ozone/actions/runs/35195541054).)
CC @jojochuang @szetszwo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
