smengcl commented on code in PR #11246: URL: https://github.com/apache/ozone/pull/11246#discussion_r4033241206
########## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/ozoneimpl/OzoneContainer.java: ########## Review Comment: Yup this patch can't handle an initializer that never returns. The heartbeat timeout limits how long the caller waits, but does not cancel the underlying startup operation. A startup watchdog would need an overall deadline and a terminal shutdown policy, accounting for legitimate long container and Raft log loading. Timing out lock acquisition alone would leave the original initializer running, and retrying partially initialized services would be unsafe. I suggest handling that separately from this PR's exception-propagation fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
