adoroszlai opened a new pull request, #67:
URL: https://github.com/apache/ozone-helm-charts/pull/67

   ## What changes were proposed in this pull request?
   
   (Similar to https://github.com/apache/ratis-thirdparty/pull/195, except the 
workflow fixes to satisfy new `zizmor-action` rules, since it is not yet 
upgraded to 0.6.4 here.)
   
   Rules introduced by new versions `zizmor-action` may fail silently in the 
[PR](https://github.com/apache/ratis-thirdparty/pull/193) that bumps ithe 
action.  Problem is 
[reported](https://github.com/apache/ratis-thirdparty/actions/runs/35067715860/job/104701697687#step:3:209)
 in details, but check still 
[passes](https://github.com/apache/ratis-thirdparty/actions/runs/35067715860).  
The failure will surface only in 
[forks](https://github.com/adoroszlai/ratis-thirdparty/actions/runs/35070400137)
 or in PRs changing the offending workflow files.
   
   With GitHub Advanced Security enabled for `zizmor-action` (the default 
setting), problems are reported in the repo's [Code 
scanning](https://github.com/apache/ratis-thirdparty/security/code-scanning) 
page.  When this feature is disabled, any problems reported cause the check to 
fail.
   
   This change keeps Advanced Security only for push events in Apache repo, 
which allows pull requests touching only `zizmor.yaml` (e.g. for version bump) 
to catch problems in other files.
   
   https://issues.apache.org/jira/browse/HDDS-16483
   
   ## How was this patch tested?
   
   Similar change tested in detail in 
https://github.com/apache/ratis-thirdparty/pull/195.
   
   zizmor check in fork:
   https://github.com/adoroszlai/ozone-helm-charts/actions/runs/35080955808
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to