ivandika3 commented on PR #10171: URL: https://github.com/apache/ozone/pull/10171#issuecomment-5693883375
Thanks @szetszwo for the review. > My understanding is that each request may add something to the cache so the response should clean them up. Why the tracker need a parent? Yes, the initial idea is that there is similar to Java `ScopedValue` and gRPC `Context.attach()` where we can have a nested scope by having a reference between the new (child) scope and the old (parent) scope in case when the parent scope has not been closed when creating a new scope. However, since OM Ratis applier only process one request at a time, then we don't need a nested scope. I've removed it. > let's make the following changes the first patch: Sure, let's reduce the scope for this patch first. The CleanupTableInfo mechanism is now reintroduced and only `OMOpenKeysDeleteRequest` and `OMOpenKeysDeleteResponse` is updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
