ivandika3 commented on PR #11056: URL: https://github.com/apache/ozone/pull/11056#issuecomment-5675707797
Thanks @adoroszlai for the review. > ErrorProne 2.50 requires Java 21, rest of Ozone build currently requires only Java 17. While CI checks are run with Java 25, I think they should still work with the base Java version (i.e. 17). Should we document this, or further bump Java requirement from 17 to 21, or downgrade ErrorProne core? Thanks for catching this. I think for now let's just use the 2.42.0 first. We can bump ErrorProne to the latest version once we require JDK21 requirement to avoid conflating these two. This patch simply wants to catch the low hanging fruits issue. > ErrorProne errors fail the build, so reactor skips dependent modules. (Reproduce by running it without the java fixes.) I think most other CI checks ignore failures during the build to analyse all modules, allowing developers to address all issues without multiple CI rounds. Is this possible with ErrorProne, too? Thanks for the info. I also encountered this while fixing the ErrorProne issues. Currently we have `-fae` which will allow unrelated modules to proceed, but the issue would still happen. Added a logic to `maven.compiler.failOnError=false` to allow build, but still failing the error-prone CI if there is an ERROR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
