devmadhuu commented on code in PR #11199:
URL: https://github.com/apache/ozone/pull/11199#discussion_r3954616817
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/fsck/ReconReplicationManager.java:
##########
@@ -313,8 +279,11 @@ public synchronized void processAll() {
// readOnly=true ensures no commands are generated
processContainer(container, replicas, pendingOps, nullQueue, report,
true);
- // ADDITIONAL CHECK: Detect REPLICA_MISMATCH (Recon-specific, not in
SCM)
- if (hasDataChecksumMismatch(replicas)) {
+ // Persist checksum mismatches in Recon's REPLICA_MISMATCH state.
+ if (container.getState() == CLOSED &&
+ container.getReplicationType() == RATIS &&
+ hasMismatch(replicas, ContainerReplica::getSequenceId,
Review Comment:
I think Recon works on eventual consistency, so we should be fine with first
option, but. logic should be consistent across SCM and Recon. Please go ahead
with first option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
