rich7420 commented on code in PR #11189:
URL: https://github.com/apache/ozone/pull/11189#discussion_r3950060524
##########
hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/endpoint/TestS3LifecycleConfigurationPut.java:
##########
@@ -266,10 +274,23 @@ private void
assertUnhandledOMExceptionPropagated(OMException omException,
.build();
endpoint.queryParamsForTest().set(S3Consts.QueryParams.LIFECYCLE, "");
- OS3Exception ex = assertThrows(OS3Exception.class,
- () -> endpoint.put("bucket1", onePrefix()));
- assertEquals(expectedHttpCode, ex.getHttpCode());
- assertEquals(expectedErrorCode, ex.getCode());
+ return assertThrows(OS3Exception.class, () -> endpoint.put("bucket1",
onePrefix()));
+ }
+
+ @Test
+ public void
testPutLifecycleConfigurationWithPastExpirationDateReturnsDetailedMessage()
throws Exception {
Review Comment:
This only mocks the gateway bucket call, so it skips Jira's RPC path
(`creationTime=0` in the gateway, then validation in OM). Please add the
past-date response assertion to both `AbstractS3SDKV1Tests` and
`AbstractS3SDKV2Tests`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
