henry3260 commented on code in PR #11174:
URL: https://github.com/apache/ozone/pull/11174#discussion_r3915055345
##########
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestEndpoints.java:
##########
@@ -960,7 +960,15 @@ public void testGetFileCounts() throws Exception {
assertTrue(o.getVolume().equals("vol1") && o.getBucket().equals("bucket1")
&&
o.getFileSize() == 131072);
- // Test for non-existent fileSize.
+ // Test for a fileSize that is not a bin boundary. It is mapped to bin
131072.
+ response = utilizationEndpoint.getFileCounts("vol1", "bucket1", 100000);
+ resultSet = (List<FileCountBySize>) response.getEntity();
+ assertEquals(1, resultSet.size());
+ o = resultSet.get(0);
+ assertTrue(o.getVolume().equals("vol1") && o.getBucket().equals("bucket1")
&&
Review Comment:
> nit: would separate `assertEquals` calls read better here? A failure
currently just says expected true.
Applied!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
