priyeshkaratha commented on code in PR #11020:
URL: https://github.com/apache/ozone/pull/11020#discussion_r3912161926
##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/ObjectAttributesHandler.java:
##########
@@ -155,11 +203,9 @@ private GetObjectAttributesResponse buildResponse(OzoneKey
key, Set<String> requ
String eTag = key.getMetadata().get(OzoneConsts.ETAG);
if (eTag != null) {
String partsCountStr = extractPartsCount(eTag);
- if (partsCountStr != null) {
- GetObjectAttributesResponse.ObjectParts parts = new
GetObjectAttributesResponse.ObjectParts();
- parts.setPartsCount(Integer.parseInt(partsCountStr));
- parts.setTruncated(false);
- resp.setObjectParts(parts);
+ if (partsCountStr != null && completedPartSizes != null) {
+ resp.setObjectParts(buildObjectParts(keyPath,
Integer.parseInt(partsCountStr),
Review Comment:
keyPath and resource are always the same value at the one call site. One of
the two parameters should be dropped
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
