rich7420 commented on code in PR #11172:
URL: https://github.com/apache/ozone/pull/11172#discussion_r3904902861
##########
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestOmDBInsightEndPoint.java:
##########
@@ -1036,8 +1033,7 @@ public void testKeysSummaryAttribute() throws IOException
{
}
private void insertGlobalStatsRecords(ReconGlobalStatsManager statsManager,
- Timestamp timestamp, String key,
- long value) throws IOException {
+ String key, long value) throws IOException {
Review Comment:
nit: `TestOmDBInsightEndPoint` doesn't look like it needs changes for the
jOOQ bump. The `Timestamp` param of `insertGlobalStatsRecords` was already
unused (the body is just `new GlobalStatsValue(value)`), so dropping it is an
independent cleanup rather than part of the version bump. No objection either
way. I can open a small follow-up issue for it if you'd rather keep this PR to
the upgrade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
