echonesis commented on code in PR #11179:
URL: https://github.com/apache/ozone/pull/11179#discussion_r3901876904
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/pipeline/Pipeline.java:
##########
@@ -519,20 +517,14 @@ public boolean equals(Object o) {
Pipeline that = (Pipeline) o;
- return new EqualsBuilder()
- .append(id, that.id)
- .append(replicationConfig, that.replicationConfig)
- .append(nodeStatus.keySet(), that.nodeStatus.keySet())
- .isEquals();
+ return id.equals(that.id)
Review Comment:
Thanks for raising this.
From the Git history, state was removed from both equals() and hashCode() in
HDDS-694. Since state transitions create a new instance for the same pipeline,
I assumed the existing behavior should be preserved and limited this change to
fixing the contract violation.
Please let me know if that interpretation is incorrect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
