rich7420 commented on PR #11058: URL: https://github.com/apache/ozone/pull/11058#issuecomment-5380650668
Micro-benchmark of the changed path (walking a key's blocks to collect container IDs), old `getLocationList()` vs new `getLocationLists()`, 300k ops/config: ``` versions x blocks | OLD | NEW 1 x 4 | 650 B/op | 0 B/op 1 x 128 | 2632 B/op | 0 B/op 4 x 32 | 3904 B/op | 0 B/op 4 x 128 | 10528 B/op | 0 B/op ``` The new path is zero-allocation (drops the per-group `ArrayList` copy) and ~6-15x faster in wall time (the old path also paid `stream/flatMap/collect` overhead). Allocation measured exactly via `ThreadMXBean.getThreadAllocatedBytes`; JMH `-prof gc` numbers to follow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
