symious commented on code in PR #10937:
URL: https://github.com/apache/ozone/pull/10937#discussion_r3834585104
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -609,6 +609,10 @@ enum Status {
LIFECYCLE_CONFIGURATION_NOT_FOUND = 102;
UPDATE_ID_NOT_MATCH = 103;
+
+ // The addressed version exists but is a delete marker. Distinct from
+ // KEY_NOT_FOUND: the S3 Gateway maps it to 405, not 404.
Review Comment:
Right, there's no 405 in s3gateway at all yet. The endpoints are a later
task in this chain, and a translateResultCode case alone wouldn't be enough (S3
also wants `x-amz-delete-marker: true`), so I've dropped the claim instead: the
comments now say the code is kept distinct so the gateway *can* answer 405,
with the mapping landing alongside the endpoints.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
