errose28 opened a new pull request, #11074: URL: https://github.com/apache/ozone/pull/11074
## What changes were proposed in this pull request? An old client's finalize upgrade command to OM should still start the finalization process. The server will need to return a different response to the old client and redirect to the new finalization flow internally. This has already been handled on SCM in [HDDS-15609](https://issues.apache.org/jira/browse/HDDS-15609). - Create a common base class to handle overlapping logic of the new and old request types in OM - Add a subclass for the new and old request types to handle their unique concerns. - Note that this does not require compatibility handling among the OMs because we must upgrade to this version before we can do ZDU with mixed OM versions. - Previously the old finalize request type had been repurposed for internal finalization among OMs, creating a compatibility issue when older clients sent that type. - This request type is now exclusively for old clients to trigger finalization, and the new internal OM finalize request has a dedicated request type. - Remove unused method `org.apache.hadoop.hdds.scm.client.ScmClient#finalizeUpgrade` left over from an earlier implementation on the feature branch where finalization started from client to SCM. The high line count is due to the new integration test and movement of existing code in the finalize requests. Most changes do not introduce new functionality. ## What is the link to the Apache JIRA HDDS-16025 ## How was this patch tested? - Unit tests for request/response types added. - Integration test added to test full cluster finalization with the old finalize and status RPCs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
