navinko commented on PR #10993: URL: https://github.com/apache/ozone/pull/10993#issuecomment-5360185591
> > ... merge master instead of git --rebase to avoid the force push in case of conflicts. > > Please do merge instead of force push. If there is a need, please ask on the PR first before force-pushing it. As a reviewer, I really want to minimize my time on reviwing. Thanks @szetszwo, makes sense. My intent was just to keep the history clean, but now am aware that it forces reviewers to re-read everything from the beginning. I'll follow the suggested approach going forward . Also in this PR particularly, do we need to redo rebase ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
