siddhantsangwan commented on PR #9790: URL: https://github.com/apache/ozone/pull/9790#issuecomment-4073815763
@ChenSammi thanks for the review. > a. as we now know that checkVolume failed twice will fail the volume, so when put block fails due to disk full, it will trigger the volume check, or directly close DB without volume check? The current behaviour is to directly close DB without volume check. This PR does not change that. > b. if read only DB instance is created, will it fail all write operations triggered by rocksdb itself, or we precheck and fail the write operations before it really call the rocksdb API? RocksDB itself will fail write operation, we don't have a pre-check. > c. once read only DB instance is created, will it be converted to read/write later if disk is no longer full? Not in this PR, but we can explore whether this is possible and do it in a future PR. Otherwise it will require a DN restart. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
