yuriipalam commented on code in PR #359:
URL: https://github.com/apache/ozone-site/pull/359#discussion_r2895069136
##########
package.json:
##########
@@ -13,8 +13,8 @@
"serve": "docusaurus serve --port 3001",
"write-translations": "docusaurus write-translations",
"write-heading-ids": "docusaurus write-heading-ids",
- "lint": "markdownlint \"$(git rev-parse --show-toplevel)\" && yamllint
--format=colored \"$(git rev-parse --show-toplevel)\"",
- "lint:fix": "markdownlint --fix \"$(git rev-parse --show-toplevel)\" &&
yamllint --format=colored \"$(git rev-parse --show-toplevel)\""
+ "lint": "eslint . && markdownlint \"$(git rev-parse --show-toplevel)\" &&
yamllint --format=colored \"$(git rev-parse --show-toplevel)\"",
+ "lint:fix": "eslint --fix . && markdownlint --fix \"$(git rev-parse
--show-toplevel)\" && yamllint --format=colored \"$(git rev-parse
--show-toplevel)\""
Review Comment:
Sure. But I'm not sure if just `.` will work with `yamllint`, since this
tool is not an npm package. Therefore, it might not run from the root of the
repo if executed not at the root. I'm not sure though, just an assumption
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
