priyeshkaratha commented on code in PR #9839:
URL: https://github.com/apache/ozone/pull/9839#discussion_r2893940671
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancerSelectionCriteria.java:
##########
@@ -158,6 +160,10 @@ private Comparator<ContainerID>
orderContainersByUsedBytes() {
public boolean shouldBeExcluded(ContainerID containerID,
DatanodeDetails node, long sizeMovedAlready) {
ContainerInfo container;
+ //If includeContainers is specified, exclude containers not in the include
list
+ if (!includeContainers.isEmpty() &&
!includeContainers.contains(containerID)) {
+ return true;
+ }
Review Comment:
can you explain the logic, how it works if a containerId added in both
include and exclude list? On what basis we are giving preference to include or
eclude?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
