devmadhuu commented on code in PR #9258:
URL: https://github.com/apache/ozone/pull/9258#discussion_r2885077106
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/types/UnhealthyContainerMetadata.java:
##########
@@ -61,15 +60,18 @@ public class UnhealthyContainerMetadata {
@XmlElement(name = "replicas")
private List<ContainerHistory> replicas;
- public UnhealthyContainerMetadata(UnhealthyContainers rec,
- List<ContainerHistory> replicas, UUID pipelineID, long keyCount) {
- this.containerID = rec.getContainerId();
- this.containerState = rec.getContainerState();
- this.unhealthySince = rec.getInStateSince();
- this.actualReplicaCount = rec.getActualReplicaCount();
- this.expectedReplicaCount = rec.getExpectedReplicaCount();
- this.replicaDeltaCount = rec.getReplicaDelta();
- this.reason = rec.getReason();
+ @SuppressWarnings("checkstyle:ParameterNumber")
+ public UnhealthyContainerMetadata(long containerID, String containerState,
+ long unhealthySince, long expectedReplicaCount, long actualReplicaCount,
+ long replicaDeltaCount, String reason, List<ContainerHistory> replicas,
+ UUID pipelineID, long keyCount) {
Review Comment:
Thanks for pointing out, I was doing some testing and did some refactoring,
so forgot to revert that. I reverted this to the previous `UnhealthyContainers`
based constructor pattern. `ContainerEndpoint` now constructs the
jOOQ-generated POJO and passes it into `UnhealthyContainerMetadata`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
