adoroszlai commented on code in PR #9863:
URL: https://github.com/apache/ozone/pull/9863#discussion_r2883842761
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/HddsDatanodeService.java:
##########
@@ -313,9 +316,11 @@ public String getNamespace() {
this::reconfigReplicationStreamsLimit);
scmServiceId = HddsUtils.getScmServiceId(conf);
+
if (scmServiceId != null) {
- reconfigurationHandler.register(OZONE_SCM_NODES_KEY + "." +
scmServiceId,
- this::reconfigScmNodes);
+ ((DatanodeReconfigurationHandler) reconfigurationHandler)
Review Comment:
Should `reconfigurationHandler` be declared as
`DatanodeReconfigurationHandler` to avoid this cast? (Also need to split
instantiation and `register()` calls.) Or even add prefix support in
`ReconfigurationHandler` and skip introducing the new subclass?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
