sarvekshayr commented on code in PR #9712:
URL: https://github.com/apache/ozone/pull/9712#discussion_r2785988038
##########
hadoop-ozone/cli-admin/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/DiskBalancerReportSubcommand.java:
##########
@@ -91,15 +95,20 @@ private String
generateReport(List<DatanodeDiskBalancerInfoProto> protos) {
Double.compare(b.getCurrentVolumeDensitySum(),
a.getCurrentVolumeDensitySum()));
StringBuilder formatBuilder = new StringBuilder("Report result:%n" +
- "%-50s %s%n");
+ "%-55s %s%n");
List<String> contentList = new ArrayList<>();
contentList.add("Datanode");
contentList.add("VolumeDensity");
for (DatanodeDiskBalancerInfoProto proto : sortedProtos) {
formatBuilder.append("%-50s %s%n");
Review Comment:
Change data rows to use `%-55s` to match header width.
##########
hadoop-ozone/cli-admin/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/DiskBalancerStatusSubcommand.java:
##########
@@ -102,12 +106,17 @@ private String
generateStatus(List<DatanodeDiskBalancerInfoProto> protos) {
contentList.add("EstTimeLeft(min)");
for (HddsProtos.DatanodeDiskBalancerInfoProto proto : protos) {
- formatBuilder.append("%-35s %-15s %-15s %-15s %-12s %-20s %-12s %-12s
%-15s %-18s %-20s%n");
+ formatBuilder.append("%-60s %-12s %-15s %-15s %-12s %-20s %-12s %-12s
%-15s %-18s %-20s%n");
Review Comment:
Here as well, let's match header and data row widths.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
