Gargi-jais11 commented on PR #8915: URL: https://github.com/apache/ozone/pull/8915#issuecomment-3311799244
> > But I think how can we get size on Datanode side while choosing volume in the below place, so its better to send replicate size from SCM. Since in chhoseNextVolume we need to pass size in order to reserve space. > > We don't need to make changes to pull replication (`DownloadAndImportReplicator`) because we don't use it anymore. We only need to support push replication. In push replication, the datanode that is sending the container can send the container's size to the datanode that's receiving the container. SCM doesn't need to send the size and that keeps this change simpler since it avoids making proto changes in the SCM to DN communication. > > Moreover, datanode knows the correct size of the container. SCM's knowledge of the container's size is outdated if there have been block deletions and the size has reduced. Thank you @siddhantsangwan for this information. I will do changes according to push replication. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org
