sarvekshayr commented on code in PR #9001:
URL: https://github.com/apache/ozone/pull/9001#discussion_r2329909174
##########
hadoop-ozone/dist/src/main/smoketest/admincli/container.robot:
##########
@@ -93,6 +93,11 @@ Container info
Should contain ${output} Pipeline id
Should contain ${output} Datanodes
+Container info should fail with invalid container ID
+ ${output} = Execute And Ignore Error ozone admin
container info "${CONTAINER}" -2 0.5 abc
+ Should contain ${output} Container IDs must
be positive integers.
+ Should contain ${output} Invalid container
IDs: -2 0.5 abc
Review Comment:
Just noticed that "${CONTAINER}" corresponds to valid container ID. You can
ignore my comment.
##########
hadoop-ozone/dist/src/main/smoketest/admincli/container.robot:
##########
@@ -93,6 +93,11 @@ Container info
Should contain ${output} Pipeline id
Should contain ${output} Datanodes
+Container info should fail with invalid container ID
+ ${output} = Execute And Ignore Error ozone admin
container info "${CONTAINER}" -2 0.5 abc
+ Should contain ${output} Container IDs must
be positive integers.
+ Should contain ${output} Invalid container
IDs: -2 0.5 abc
Review Comment:
Could you also include a valid container ID along with the invalid ones to
verify that it’s skipped during validation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
