Wei-Chiu Chuang created HDDS-13624:
--------------------------------------
Summary: ManagedWriteOptions not closed if DBStoreBuilder.build
fails to get DB store
Key: HDDS-13624
URL: https://issues.apache.org/jira/browse/HDDS-13624
Project: Apache Ozone
Issue Type: Bug
Components: Ozone Datanode
Reporter: Wei-Chiu Chuang
Found a potential resource leak if DataNode fails to instantiate a rocksdb
instance.
Log:
{noformat}
2025-08-27 20:23:53,920 ERROR
[ChunkReader-16]-org.apache.hadoop.ozone.container.common.utils.DatanodeStoreCache:
Failed to get DB store /data/2/hadoop-ozon
e/datanode/data131872/hdds/CID-40bbec93-9c60-4d0a-9c3a-02c00175cf47/DS-cac28772-bf58-44ab-9a56-7dac68dbc6c4/container.db
java.io.IOException: The DB destination directory should exist.
at
org.apache.hadoop.hdds.utils.db.DBStoreBuilder.build(DBStoreBuilder.java:232)
at
org.apache.hadoop.ozone.container.metadata.AbstractDatanodeStore.initDBStore(AbstractDatanodeStore.java:93)
at
org.apache.hadoop.ozone.container.metadata.AbstractRDBStore.start(AbstractRDBStore.java:77)
at
org.apache.hadoop.ozone.container.metadata.AbstractRDBStore.<init>(AbstractRDBStore.java:59)
at
org.apache.hadoop.ozone.container.metadata.AbstractDatanodeStore.<init>(AbstractDatanodeStore.java:69)
at
org.apache.hadoop.ozone.container.metadata.DatanodeStoreSchemaThreeImpl.<init>(DatanodeStoreSchemaThreeImpl.java:72)
at
org.apache.hadoop.ozone.container.common.utils.DatanodeStoreCache.getDB(DatanodeStoreCache.java:77)
at
org.apache.hadoop.ozone.container.keyvalue.helpers.BlockUtils.getDB(BlockUtils.java:134)
at
org.apache.hadoop.ozone.container.keyvalue.impl.BlockManagerImpl.persistPutBlock(BlockManagerImpl.java:122)
at
org.apache.hadoop.ozone.container.keyvalue.impl.BlockManagerImpl.putBlock(BlockManagerImpl.java:103)
at
org.apache.hadoop.ozone.container.keyvalue.KeyValueHandler.handlePutBlock(KeyValueHandler.java:589)
at
....
2025-08-27 20:23:53,920 WARN
[Finalizer]-org.apache.hadoop.hdds.utils.db.managed.ManagedRocksObjectUtils:
ManagedWriteOptions is not closed properly
{noformat}
I believe we should catch the exception and close the ManagedWriteOptions
object here:
https://github.com/apache/ozone/blob/master/hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/DBStoreBuilder.java#L228
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
