adoroszlai commented on code in PR #8891:
URL: https://github.com/apache/ozone/pull/8891#discussion_r2250526907
##########
pom.xml:
##########
@@ -1818,9 +1818,19 @@
<artifactId>maven-javadoc-plugin</artifactId>
<version>${maven-javadoc-plugin.version}</version>
<configuration>
+ <sourceFileExcludes>
+ <exclude>**/package-info.java</exclude>
+ </sourceFileExcludes>
<doclint>none</doclint>
<notimestamp>true</notimestamp>
</configuration>
+ <dependencies>
+ <dependency>
+ <groupId>com.google.protobuf</groupId>
+ <artifactId>protobuf-java</artifactId>
+ <version>${grpc.protobuf-compile.version}</version>
+ </dependency>
+ </dependencies>
Review Comment:
Instead of adding protobuf as depenency, I think we should skip creating
javadoc for generated code. Please see HDDS-11142.
##########
hadoop-ozone/mini-cluster/pom.xml:
##########
@@ -25,6 +25,10 @@
<name>Apache Ozone Mini Cluster</name>
<description>Apache Ozone Mini Cluster for Integration Tests</description>
+ <properties>
Review Comment:
@jojochuang you have reported the failure in this module:
```
hadoop-ozone/mini-cluster/src/main/java/org/apache/hadoop/ozone/MiniOzoneHAClusterImpl.java:22:
error: package org.apache.ozone.test.GenericTestUtils does not exist
[ERROR] import static
org.apache.ozone.test.GenericTestUtils.PortAllocator.getFreePort;
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
