adoroszlai commented on code in PR #8854:
URL: https://github.com/apache/ozone/pull/8854#discussion_r2246886643
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/ozoneimpl/OnDemandContainerScanner.java:
##########
@@ -87,9 +87,13 @@ private Optional<Future<?>> scanContainer(Container<?>
container, ContainerScanH
long containerId = container.getContainerData().getContainerID();
if (addContainerToScheduledContainers(containerId)) {
resultFuture = scanExecutor.submit(() -> {
- performOnDemandScan(container, helper);
+ performOnDemandScan(container, helper, reasonForScan);
removeContainerFromScheduledContainers(containerId);
});
+ } else {
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("Skipping OnDemandScan for Container {}, Reason: {}",
containerId, "Already scheduled.");
Review Comment:
Shouldn't we log the original reason?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
