sadanand48 commented on code in PR #8874:
URL: https://github.com/apache/ozone/pull/8874#discussion_r2243665870


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/KeyDeletingService.java:
##########
@@ -164,15 +164,23 @@ Pair<Integer, Boolean> processKeyDeletes(List<BlockGroup> 
keyBlocksList,
    * @param results DeleteBlockGroups returned by SCM.
    * @param keysToModify Updated list of RepeatedOmKeyInfo
    */
-  private Pair<Integer, Boolean> 
submitPurgeKeysRequest(List<DeleteBlockGroupResult> results,
-      Map<String, RepeatedOmKeyInfo> keysToModify,  List<String> 
renameEntriesToBeDeleted,
-      String snapTableKey, UUID expectedPreviousSnapshotId) throws 
InterruptedException {
+  @SuppressWarnings("checkstyle:MethodLength")
+  private Pair<Integer, Boolean> submitPurgeKeysRequest(

Review Comment:
   ```
   getPendingDeletionKeys(
         CheckedFunction<Table.KeyValue<String, OmKeyInfo>, Boolean, 
IOException> filter, int count, int ratisByteLimit)
   ```  
   -> this method returns the entries limited by ratisByte limit which should 
not  happen anymore.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org

Reply via email to