kostacie commented on code in PR #8838:
URL: https://github.com/apache/ozone/pull/8838#discussion_r2225292490
##########
hadoop-ozone/dist/src/main/smoketest/compatibility/read.robot:
##########
@@ -155,3 +155,16 @@ HSync Lease Recover Can Be Used
Pass Execution If '${CLIENT_VERSION}' < '${HSYNC_VERSION}' Client
does not support HSYNC
Pass Execution If '${CLUSTER_VERSION}' < '${HSYNC_VERSION}' Cluster
does not support HSYNC
Execute ozone admin om lease recover
--path=ofs://om/vol1/fso-bucket-${DATA_VERSION}/dir/subdir/file
+
+Key Info File Flag Should Be Set Correctly
+ Pass Execution If '${CLUSTER_VERSION}' <= '${EC_VERSION}' Cluster
does not support 'file' flag
+ Pass Execution If '${CLIENT_VERSION}' <= '${EC_VERSION}' Client does
not support 'file' flag
Review Comment:
@ptlrs thank you for the review. Does it mean that we should log a result of
the `ozone sh key info`? Or what would you suggest to do?
I've just tested it and the results for older/newer clients or servers are
different considering current changes, e.g.:
- `xcompat-cluster-1.1.0-client-1.1.0-read-2.1.0` doesn't contain the 'file'
status;
- `xcompat-cluster-1.1.0-client-2.1.0-read-1.1.0` sets `'file' : false` for
the file and `'false'` for the directory;
- `xcompat-cluster-2.1.0-client-1.1.0-read-1.1.0` doesn't contain the 'file'
status;
- `xcompat-cluster-2.1.0-client-1.4.1-read-1.4.1` sets `'file' : true` for
the directory;
- `xcompat-cluster-2.1.0-client-2.0.0-read-2.0.0` sets `'file' : true` for
the directory;
I wonder why the results are incorrect for 1.4.1 and newer versions after
removing manual creation of volume, bucket, key and directory from the test.
Before that, it worked fine for >1.3 versions. Can it be related to the type of
created bucket in some test or is there other explanation for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
