aryangupta1998 commented on code in PR #8815: URL: https://github.com/apache/ozone/pull/8815#discussion_r2215196102
########## hadoop-ozone/tools/src/test/java/org/apache/hadoop/ozone/repair/ldb/TestLdbRepair.java: ########## @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.repair.ldb; + +import static org.apache.ozone.test.IntLambda.withTextFromSystemIn; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertTrue; + +import java.io.IOException; +import java.nio.charset.StandardCharsets; +import java.nio.file.Files; +import java.nio.file.Path; +import java.util.ArrayList; +import java.util.Collections; +import java.util.List; +import java.util.stream.Stream; +import org.apache.commons.lang3.RandomStringUtils; +import org.apache.hadoop.hdds.conf.OzoneConfiguration; +import org.apache.hadoop.hdds.utils.db.CodecBuffer; +import org.apache.hadoop.hdds.utils.db.DBStoreBuilder; +import org.apache.hadoop.hdds.utils.db.RDBStore; +import org.apache.hadoop.hdds.utils.db.Table; +import org.apache.hadoop.hdds.utils.db.managed.ManagedRocksDB; +import org.apache.hadoop.ozone.debug.RocksDBUtils; +import org.apache.ozone.rocksdb.util.RdbUtil; +import org.junit.jupiter.api.AfterEach; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.io.TempDir; +import org.rocksdb.ColumnFamilyDescriptor; +import org.rocksdb.ColumnFamilyHandle; +import org.rocksdb.LiveFileMetaData; +import picocli.CommandLine; + +/** + * Tests for RocksDB LDB repair tools. + */ +public class TestLdbRepair { + + private static final String TEST_CF_NAME = "testColumnFamily"; + private static final int NUM_KEYS = 100; + + @TempDir + private Path tempDir; + private Path dbPath; + private RDBStore rdbStore; + + @BeforeEach + public void setUp() throws Exception { + CodecBuffer.enableLeakDetection(); + dbPath = tempDir.resolve("test.db"); + rdbStore = DBStoreBuilder.newBuilder(new OzoneConfiguration()) + .setName(dbPath.toFile().getName()) + .setPath(dbPath.getParent()) + .addTable(TEST_CF_NAME) + .build(); + } + + @AfterEach + public void tearDown() throws Exception { + if (rdbStore != null && !rdbStore.isClosed()) { + rdbStore.close(); + } + CodecBuffer.assertNoLeaks(); + } + + /** + * Test manual compaction of RocksDB. + * This test creates a large number of keys, deletes them (creating tombstones), + * and then runs manual compaction via the CLI tool. + * It verifies the following: + * Compaction command executes successfully. + * Tombstones are removed (i.e., numDeletions in SST files is 0). + * Size of the db reduces after compaction. + */ + @Test + public void testRocksDBManualCompaction() throws Exception { + Table<byte[], byte[]> testTable = rdbStore.getTable(TEST_CF_NAME); + + // Create many keys + for (int i = 0; i < NUM_KEYS; i++) { + String key = "key" + i; + String value = RandomStringUtils.secure().nextAlphanumeric(100); + testTable.put(key.getBytes(StandardCharsets.UTF_8), value.getBytes(StandardCharsets.UTF_8)); + } + rdbStore.flushDB(); + long sizeAfterKeysCreate = calculateSstFileSize(dbPath); + + // Delete all keys + for (int i = 0; i < NUM_KEYS; i++) { + String key = "key" + i; + testTable.delete(key.getBytes(StandardCharsets.UTF_8)); + } + rdbStore.flushDB(); + long sizeAfterKeysDelete = calculateSstFileSize(dbPath); + rdbStore.close(); + + // Trigger compaction of the table + RocksDBManualCompaction compactionTool = new RocksDBManualCompaction(); + CommandLine cmd = new CommandLine(compactionTool); + String[] args = { + "--db", dbPath.toString(), + "--column-family", TEST_CF_NAME + }; + int exitCode = withTextFromSystemIn("y") + .execute(() -> cmd.execute(args)); + assertEquals(0, exitCode, "Compaction command should execute successfully"); + long sizeAfterCompaction = calculateSstFileSize(dbPath); + + System.out.printf("Size after creating keys: %d, after deleting keys: %d, after compaction: %d %n", + sizeAfterKeysCreate, sizeAfterKeysDelete, sizeAfterCompaction); + + // Deletes should increase the size due to tombstones + assertTrue(sizeAfterKeysCreate < sizeAfterKeysDelete, + String.format("sizeAfterKeysCreate (%d) is not lesser than sizeAfterKeysDelete (%d), ", + sizeAfterKeysCreate, sizeAfterKeysDelete)); + // Compaction should reduce the size below original + assertTrue(sizeAfterCompaction < sizeAfterKeysCreate, + String.format("sizeAfterCompaction (%d) is not lesser than sizeAfterKeysCreate (%d), ", + sizeAfterCompaction, sizeAfterKeysCreate)); + // check all tombstones were removed + List<ColumnFamilyHandle> cfHandleList = new ArrayList<>(); + List<ColumnFamilyDescriptor> cfDescList = RocksDBUtils.getColumnFamilyDescriptors(dbPath.toString()); + try (ManagedRocksDB db = ManagedRocksDB.open(dbPath.toString(), cfDescList, cfHandleList)) { + List<LiveFileMetaData> liveFileMetaDataList = RdbUtil + .getLiveSSTFilesForCFs(db, Collections.singletonList(TEST_CF_NAME)); + for (LiveFileMetaData liveMetadata : liveFileMetaDataList) { + assertEquals(0, liveMetadata.numDeletions(), + "Tombstones found in file: " + liveMetadata.fileName()); + } + } + } + + private long calculateSstFileSize(Path db) throws IOException { + if (!Files.exists(db)) { + return 0; + } Review Comment: ```suggestion if (!Files.exists(db)) { throw new IllegalStateException("DB path doesn't exist: " + db); } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org
