smengcl commented on code in PR #8820:
URL: https://github.com/apache/ozone/pull/8820#discussion_r2214007833
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/commandhandler/DeleteBlocksCommandHandler.java:
##########
@@ -333,6 +333,10 @@ public DeleteBlockTransactionExecutionResult call() {
"container={}, TXID={}", tx.getContainerID(), tx.getTxID(), e);
Thread.currentThread().interrupt();
txResultBuilder.setContainerID(containerId).setSuccess(false);
+ } catch (Exception e) {
Review Comment:
Hi @swamirishi , originally I put `Throwable`. But I then took copilot's
advice and changed it to `Exception` instead.
https://github.com/apache/ozone/pull/8820#discussion_r2211852142
`Throwable` could indeed catch too many other types of stuff that we don't
intend to catch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
