Gargi-jais11 commented on code in PR #8693:
URL: https://github.com/apache/ozone/pull/8693#discussion_r2212062235
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerService.java:
##########
@@ -507,13 +524,21 @@ public BackgroundTaskResult call() {
.incrementUsedSpace(containerSize);
destVolumeIncreased = true;
- // Update container for containerID
+ // Step 4: New Container state transition, C1-RECOVERING -> C1-CLOSING
+ newContainer.getContainerData().setState(
Review Comment:
So instead of above code it should be changed to something like this :
```
Container newContainer = ozoneContainer.getController()
.importContainer(containerData, diskBalancerDestDir);
```
and other parts should be removed because if we pass below
**originalContainerData** which is in turn containerData created from
**diskBalancerDestDir** then it will end up leaving the newContainer created as
RECOVERING state only.
```
File containerFile = ContainerUtils.getContainerFile(
diskBalancerDestDir.toFile());
if (!containerFile.exists()) {
throw new IOException("ContainerFile for container " + containerId
+ " doesn't exists.");
}
ContainerData originalContainerData = ContainerDataYaml
.readContainerFile(containerFile);
```
Does this sound relevant to you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
