tanvipenumudy commented on code in PR #8809:
URL: https://github.com/apache/ozone/pull/8809#discussion_r2210180803
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/types/ReconBasicOmKeyInfo.java:
##########
@@ -247,6 +247,30 @@ public static ReconBasicOmKeyInfo
getFromProtobuf(OzoneManagerProtocolProtos.Key
return builder.build();
}
+ public static ReconBasicOmKeyInfo
getFromProtobuf(OzoneManagerProtocolProtos.KeyInfo keyInfoProto) {
Review Comment:
That's correct, the PR only addresses one half of the issue with performance.
> PartKeyInfo is using KeyInfo proto and even though you are not using
keylocations and other fields, these fields will still be decoded from byte
buffer to proto fields
To optimize this further, we may need a new implementation of PartKeyInfoMap
that uses an updated version of Iterable<PartKeyInfo> based on the
KeyInfoProtoLight proto object instead of KeyInfo. However, this could require
significant changes, not sure if there's a good way to handle this!
cc: @sumitagrawl
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
