sumitagrawl commented on code in PR #8788:
URL: https://github.com/apache/ozone/pull/8788#discussion_r2201050450
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ContainerManager.java:
##########
@@ -72,6 +74,42 @@ default List<ContainerInfo> getContainers() {
*/
List<ContainerInfo> getContainers(ContainerID startID, int count);
+<<<<<<< Updated upstream
Review Comment:
seems some temporary changes for this, resolve it
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/util/SeekableIterator.java:
##########
@@ -25,4 +25,6 @@
*/
public interface SeekableIterator<K, E> extends ClosableIterator<E> {
void seek(K position) throws IOException;
+
+ K peekNextKey();
Review Comment:
this is not an standard method for the Iterator. Need use next() as already
provided
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/states/ContainerStateMap.java:
##########
@@ -17,11 +17,19 @@
package org.apache.hadoop.hdds.scm.container.states;
+<<<<<<< Updated upstream
+=======
+import com.google.common.annotations.VisibleForTesting;
Review Comment:
We should avoid changing SCM for Recon cases ... seems below may need
increase memory need for SCM also. please recheck.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]