[
https://issues.apache.org/jira/browse/HDDS-13362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ivan Andika updated HDDS-13362:
-------------------------------
Description:
We need to ensure that abstract OM response class should NOT have
CleanupTableInfo annotation values since the OM response subclass
CleanupTableInfo annotation values will override the parent CleanupTableInfo.
The abstract class @CleanupTableInfo will lull the new contributor to exclude
it in the CleanupTableInfo of thee subclass. Currently we these abstract
classes:
* AbstractS3MultipartAbortResponse
* AbstractOMKeyDeleteResponse
Ideally, CleanupTableInfo should be built by checking the
OMClientRequest#validateAndUpdateCache implementation for any cache update,
instead of hardcoding CleanupTableInfo in the OM response, which is very prone
to human error. However, this improvement might be quite involved and can be
handled in a separate ticket.
was:
We need to ensure that no abstract OM response class should have
CleanupTableInfo since it is not going to be picked up by
OzoneManagerDoubleBuffer and will lull the new contributor to exclude it in the
CleanupTableInfo. Currently we these abstract classes:
* AbstractS3MultipartAbortResponse
* AbstractOMKeyDeleteResponse
Ideally, CleanupTableInfo should be built by checking the
OMClientRequest#validateAndUpdateCache implementation for any cache update,
instead of hardcoding CleanupTableInfo in the OM response, which is very prone
to human error. However, this improvement might be quite involved and can be
handled in a separate ticket.
> Abstract OM response class should not be annotated with CleanupTableInfo
> ------------------------------------------------------------------------
>
> Key: HDDS-13362
> URL: https://issues.apache.org/jira/browse/HDDS-13362
> Project: Apache Ozone
> Issue Type: Sub-task
> Reporter: Ivan Andika
> Assignee: Ivan Andika
> Priority: Major
>
> We need to ensure that abstract OM response class should NOT have
> CleanupTableInfo annotation values since the OM response subclass
> CleanupTableInfo annotation values will override the parent CleanupTableInfo.
> The abstract class @CleanupTableInfo will lull the new contributor to exclude
> it in the CleanupTableInfo of thee subclass. Currently we these abstract
> classes:
> * AbstractS3MultipartAbortResponse
> * AbstractOMKeyDeleteResponse
> Ideally, CleanupTableInfo should be built by checking the
> OMClientRequest#validateAndUpdateCache implementation for any cache update,
> instead of hardcoding CleanupTableInfo in the OM response, which is very
> prone to human error. However, this improvement might be quite involved and
> can be handled in a separate ticket.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
