devmadhuu commented on PR #8688: URL: https://github.com/apache/ozone/pull/8688#issuecomment-3003691143
> Thanks for the changes @devmadhuu Changes LGTM +1 > > Just one Idea for future Improvement if necessary - `ReconContext.getErrors().add(ReconContext.ErrorCode.INTERNAL_ERROR)` is used everywhere. > > Suggestion: If possible, ca we use more specific error codes (or extend the enum) to distinguish between different failing components (e.g., SCM_NOT_INITIALIZED, OMSP_NOT_INITIALIZED), making debugging easier via the health endpoint. Thanks @ArafatKhan2198 for your review. Yes thats the plan in future when we start using reconContext and expose on Recon UI through an API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
