adoroszlai commented on code in PR #8684:
URL: https://github.com/apache/ozone/pull/8684#discussion_r2162905912
##########
pom.xml:
##########
@@ -2120,6 +2120,23 @@
</rules>
</configuration>
</execution>
+ <execution>
+ <id>ban-jetty-stringutil</id>
+ <goals>
+ <goal>enforce</goal>
+ </goals>
+ <phase>process-sources</phase>
+ <configuration>
+ <rules>
+ <restrictImports>
+ <reason>Jetty's StringUtil is disabled by default.
Replace it with Apache Common's StringUtils.</reason>
Review Comment:
"disabled by default" only applies to annotation processing.
```suggestion
<reason>Use similar class from Apache Commons
Lang</reason>
```
##########
pom.xml:
##########
@@ -2120,6 +2120,23 @@
</rules>
</configuration>
</execution>
+ <execution>
+ <id>ban-jetty-stringutil</id>
+ <goals>
+ <goal>enforce</goal>
+ </goals>
+ <phase>process-sources</phase>
+ <configuration>
+ <rules>
+ <restrictImports>
+ <reason>Jetty's StringUtil is disabled by default.
Replace it with Apache Common's StringUtils.</reason>
+ <bannedImports>
+
<bannedImport>org.eclipse.jetty.util.StringUtil</bannedImport>
+ </bannedImports>
+ </restrictImports>
Review Comment:
No need for a new `<execution>`, please move this to existing one:
https://github.com/apache/ozone/blob/25ba1be825814e63766ab99132342b46b282ad9b/pom.xml#L1977-L1985
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
