siddhantsangwan commented on code in PR #8642:
URL: https://github.com/apache/ozone/pull/8642#discussion_r2161808660
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/HddsDispatcher.java:
##########
@@ -335,8 +334,22 @@ && getMissingContainerSet().contains(containerID)) {
}
// Small performance optimization. We check if the operation is of type
// write before trying to send CloseContainerAction.
+ boolean isVolumeFullForWrite = false;
if (!HddsUtils.isReadOnly(msg)) {
- sendCloseContainerActionIfNeeded(container);
+ try {
+ if (container != null && container.getContainerState() == State.OPEN) {
+ ContainerUtils.assertSpaceAvailability(containerID,
container.getContainerData().getVolume(), 0);
+ }
+ } catch (StorageContainerException e) {
+ LOG.warn(e.getMessage());
Review Comment:
We should add the actual path of the volume to the message being constructed
in `assertSpaceAvailability` to help in figuring out which volume is full.
Right now it just has the volume UUID.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
