adoroszlai commented on code in PR #8632:
URL: https://github.com/apache/ozone/pull/8632#discussion_r2154789752
##########
hadoop-ozone/dist/src/main/smoketest/__init__.robot:
##########
@@ -16,4 +16,5 @@
Documentation Smoketest ozone secure cluster
Test Timeout 10 minutes
Resource commonlib.robot
-Suite Setup Run Keyword if '${SECURITY_ENABLED}' == 'true' Kinit
test user testuser testuser.keytab
+Suite Setup Run Keywords Get Security Enabled From Config
+... AND Run Keyword if '${SECURITY_ENABLED}' == 'true' Kinit
test user testuser testuser.keytab
Review Comment:
Let's:
- add `Get Security Enabled From Config` as first step in `Kinit test user`
keyword
- remove `Run Keyword if` and condition; `Kinit test user` already checks
that
(Also in other files where `Suite Setup` is the same as here.)
##########
hadoop-ozone/dist/src/main/smoketest/admincli/container.robot:
##########
@@ -18,7 +18,9 @@ Documentation Test ozone admin container command
Library BuiltIn
Resource ../commonlib.robot
Test Timeout 5 minutes
-Suite Setup Create test data
+Suite Setup Run Keywords Create test data
+... AND Get Security Enabled From Config
+
Review Comment:
`Get Security Enabled From Config` needs to be first. I also suggest moving
it to `Create test data`.
##########
hadoop-ozone/dist/src/main/smoketest/commonlib.robot:
##########
@@ -31,6 +31,13 @@ Get test user principal
${instance} = Execute hostname | sed
's/scm[0-9].org/scm/;s/scm[0-9]/scm/;s/om[0-9]/om/'
[return] ${user}/${instance}@EXAMPLE.COM
+Get Security Enabled From Config
+ ${value} = Execute ozone getconf confKey ozone.security.enabled
Review Comment:
Let's add a check as first step: `Return From Keyword If
'${SECURITY_ENABLED}' != ''` (or similar), to save some time on repeated calls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
