aswinshakil commented on code in PR #8649:
URL: https://github.com/apache/ozone/pull/8649#discussion_r2154203323
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/checksum/ContainerMerkleTreeWriter.java:
##########
@@ -219,7 +219,7 @@ private static class ChunkMerkleTreeWriter {
ChunkMerkleTreeWriter(ContainerProtos.ChunkMerkleTree chunkTree) {
length = chunkTree.getLength();
offset = chunkTree.getOffset();
- isHealthy = chunkTree.getIsHealthy();
+ isHealthy = chunkTree.getChecksumMatches();
Review Comment:
Can we also change `isHealthy` to something like `checksumMatches` and make
it consistent across the code?
##########
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/checksum/TestContainerMerkleTreeWriter.java:
##########
@@ -293,7 +293,7 @@ private ContainerProtos.ChunkMerkleTree
buildExpectedChunkTree(ContainerProtos.C
.setOffset(chunk.getOffset())
.setLength(chunk.getLen())
.setDataChecksum(computeExpectedChunkChecksum(chunk.getChecksumData().getChecksumsList()))
- .setIsHealthy(isHealthy)
+ .setChecksumMatches(isHealthy)
Review Comment:
Same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
