[ 
https://issues.apache.org/jira/browse/HDDS-11530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17981698#comment-17981698
 ] 

Chu Cheng Li commented on HDDS-11530:
-------------------------------------

Yeah. Thanks for catching this, I think the the current logic is wrong.
The spec says: 
> For general purpose buckets, {{key-marker}} is an object key. Together with 
>{{{}upload-id-marker{}}}, this parameter specifies the multipart upload after 
>which listing should begin.

> If {{upload-id-marker}} is not specified, only the keys lexicographically 
> greater than the specified {{key-marker}} will be included in the list.

> If {{upload-id-marker}} is specified, any multipart uploads for a key equal 
> to the {{key-marker}} might also be included, provided those multipart 
> uploads have upload IDs lexicographically greater than the specified 
> {{{}upload-id-marker{}}}.

But the current approach would be:
> ...

> If {{upload-id-marker}} is not specified, only the keys lexicographically 
> greater than *or equal to* the specified {{key-marker}} will be included in 
> the list.
> ...

 

---

 

Also the nextKeyMarker and nextUploadId should be the last element of the 
return list, too.

 

---

Just created a ticket for this - 
https://issues.apache.org/jira/browse/HDDS-13290

> Support listMultipartUploads max uploads and markers
> ----------------------------------------------------
>
>                 Key: HDDS-11530
>                 URL: https://issues.apache.org/jira/browse/HDDS-11530
>             Project: Apache Ozone
>          Issue Type: Sub-task
>          Components: OM, s3gateway
>            Reporter: Ivan Andika
>            Assignee: Chu Cheng Li
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 2.0.0
>
>
> [https://docs.aws.amazon.com/AmazonS3/latest/API/API_ListMultipartUploads.html]
> Currently, ListMultipartUploads will only list up to 1000 multipart uploads 
> by default or it can be configured by passing optional max-uploads 
> parameters. If there are more multipart uploads than the requested multipart 
> uploads, ListMultipartUploadsResult returned should set isTruncated flag, and 
> NextKeyMarker and NextUploadIdMarker for the subsequent listMultipartUploads.
> Currently S3G does not support this, it will return all the multipart 
> uploads. We can implement this feature to limit the amount of multipart 
> uploads returned from a single listMultipartUploads call.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to