adoroszlai opened a new pull request, #8628:
URL: https://github.com/apache/ozone/pull/8628

   ## What changes were proposed in this pull request?
   
   Simplify `CheckNative` implementation, reducing duplication.
   
   Also improve output a bit by align columns.
   
   https://issues.apache.org/jira/browse/HDDS-13275
   
   ## How was this patch tested?
   
   Without any native lib:
   
   ```
   $ hadoop-ozone/dist/target/ozone-2.1.0-SNAPSHOT/bin/ozone debug checknative  
                                                             
   Native library checking:
        hadoop:  false  
         ISA-L:  false  hadoop native library cannot be loaded.
       OpenSSL:  false  
   rocks-tools:  false  
   ```
   
   With Hadoop 3.4.1:
   
   ```
   $ LD_LIBRARY_PATH=~/tmp/hadoop-3.4.1/lib/native:$LD_LIBRARY_PATH 
hadoop-ozone/dist/target/ozone-2.1.0-SNAPSHOT/bin/ozone debug checknative
   Native library checking:
        hadoop:  true   ~/tmp/hadoop-3.4.1/lib/native/libhadoop.so.1.0.0
         ISA-L:  false  Loading ISA-L failed: Failed to load libisal.so.2 
(libisal.so.2: cannot open shared object file: No such file or directory)
       OpenSSL:  false  Cannot load libcrypto.so (libcrypto.so: cannot open 
shared object file: No such file or directory)!
   rocks-tools:  false  
   ```
   
   With Ozone native lib (after build with `-Drocks_tools_native`):
   
   ```
   Native library checking:
        hadoop:  false  
         ISA-L:  false  hadoop native library cannot be loaded.
       OpenSSL:  false  
   rocks-tools:  true   libozone_rocksdb_tools.so
   ```
   
   With both:
   
   ```
   Native library checking:
        hadoop:  true   ~/tmp/hadoop-3.4.1/lib/native/libhadoop.so.1.0.0
         ISA-L:  false  Loading ISA-L failed: Failed to load libisal.so.2 
(libisal.so.2: cannot open shared object file: No such file or directory)
       OpenSSL:  false  Cannot load libcrypto.so (libcrypto.so: cannot open 
shared object file: No such file or directory)!
   rocks-tools:  true   libozone_rocksdb_tools.so
   ```
   
   CI:
   https://github.com/adoroszlai/ozone/actions/runs/15652247805


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to