hevinhsu commented on PR #8558:
URL: https://github.com/apache/ozone/pull/8558#issuecomment-2969988743
Hi @ivandika3 @peterxcli ,
I've made some changes, including:
* Moved static methods in```BucketOwnerCondition``` to ```S3Owner```
* Added null/empty checks for owner fields for bucketOwner verification
* Added integration tests for LinkBucket, including:
* Normal link bucket scenario
* Dangling bucket scenario (in the current version, the owner field is not
null)
* Removed unit tests for bucket owner condition, as these scenarios are now
covered by the integration tests (let me know if you prefer to keep the unit
tests, and I can add them back)
Would you mind taking a look?
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
