swamirishi commented on code in PR #8477:
URL: https://github.com/apache/ozone/pull/8477#discussion_r2141012080
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/DBCheckpointServlet.java:
##########
@@ -196,20 +202,16 @@ private void
generateSnapshotCheckpoint(HttpServletRequest request,
flush = Boolean.parseBoolean(flushParam);
}
- List<String> receivedSstList = new ArrayList<>();
+ processMetadataSnapshotRequest(request, response, isFormData, checkpoint,
flush);
+ }
+
+ protected void processMetadataSnapshotRequest(HttpServletRequest request,
HttpServletResponse response,
+ boolean isFormData, DBCheckpoint checkpoint, boolean flush) {
Review Comment:
If you are planning to refactor some code can you please first raise a
refactoring PR. It is very tough to follow such refactoring. Right now I am not
able to understand what part of the code is refactoring vs actual logic change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
