adoroszlai commented on code in PR #46:
URL: https://github.com/apache/ozone-docker/pull/46#discussion_r2135244609


##########
docker-compose.yaml:
##########
@@ -73,3 +73,14 @@ services:
       environment:
          <<: *common-config
       command: ["ozone","s3g"]
+   httpfs:
+     <<: *image
+     ports:
+       - 14000:14000
+     environment:
+       CORE-SITE.XML_fs.defaultFS: "ofs://om"
+       CORE-SITE.XML_hadoop.proxyuser.hadoop.hosts: "*"
+       CORE-SITE.XML_hadoop.proxyuser.hadoop.groups: "*"

Review Comment:
   These need to be added in `common-config`.  Otherwise I got the following 
error when trying to put a file:
   
   ```
   httpfs-1  | 07:44:03,141 ERROR OzoneClientFactory:267 - Couldn't create 
RpcClient protocol exception: 
   httpfs-1  | 
org.apache.hadoop.ipc.RemoteException(org.apache.hadoop.security.authorize.AuthorizationException):
 User: hadoop is not allowed to impersonate hadoop
   httpfs-1  |  at org.apache.hadoop.ipc.Client.getRpcResponse(Client.java:1584)
   ...
   httpfs-1  |  at 
org.apache.hadoop.ozone.om.protocolPB.OzoneManagerProtocolClientSideTranslatorPB.getServiceInfo(OzoneManagerProtocolClientSideTranslatorPB.java:1880)
   httpfs-1  |  at 
org.apache.hadoop.ozone.client.rpc.RpcClient.<init>(RpcClient.java:260)
   ...
   httpfs-1  |  at 
org.apache.hadoop.fs.ozone.RootedOzoneClientAdapterImpl.<init>(RootedOzoneClientAdapterImpl.java:50)
   httpfs-1  |  at 
org.apache.hadoop.fs.ozone.RootedOzoneFileSystem.createAdapter(RootedOzoneFileSystem.java:108)
   httpfs-1  |  at 
org.apache.hadoop.fs.ozone.BasicRootedOzoneFileSystem.initialize(BasicRootedOzoneFileSystem.java:194)
   ...
   httpfs-1  |  at 
org.apache.ozone.lib.service.hadoop.FileSystemAccessService.createFileSystem(FileSystemAccessService.java:339)
   ...
   httpfs-1  |  at 
org.apache.ozone.fs.http.server.HttpFSServer.handleCreate(HttpFSServer.java:1229)
   httpfs-1  |  at 
org.apache.ozone.fs.http.server.HttpFSServer.put(HttpFSServer.java:901)
   ```



##########
docker-compose.yaml:
##########
@@ -73,3 +73,14 @@ services:
       environment:
          <<: *common-config
       command: ["ozone","s3g"]
+   httpfs:
+     <<: *image
+     ports:
+       - 14000:14000

Review Comment:
   nit: the rest of this file has indentation of 3 spaces, please use the same 
for the new service.



##########
docker-compose.yaml:
##########
@@ -73,3 +73,14 @@ services:
       environment:
          <<: *common-config
       command: ["ozone","s3g"]
+   httpfs:
+     <<: *image
+     ports:
+       - 14000:14000
+     environment:
+       CORE-SITE.XML_fs.defaultFS: "ofs://om"
+       CORE-SITE.XML_hadoop.proxyuser.hadoop.hosts: "*"
+       CORE-SITE.XML_hadoop.proxyuser.hadoop.groups: "*"
+       OZONE-SITE.XML_hdds.scm.safemode.min.datanode: 
${OZONE_SAFEMODE_MIN_DATANODES:-1}

Review Comment:
   `hdds.scm.safemode.min.datanode` is not needed for `httpfs`, can be removed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org

Reply via email to