siddhantsangwan commented on PR #8492: URL: https://github.com/apache/ozone/pull/8492#issuecomment-2954967269
> I think purpose of sending full volume report is avoiding pipeline and container creation. Now node report is throttled and hence close container is throttled implicitly. Initial purpose was close container immediate to avoid new block allocation for the HB time (ie 30 second). > This may be similar to sending DN HB, only advantage here is for first failure within 1 min, its immediate, but all later failure is throttled. Based on this comment, we decided to trigger heartbeat immediately when: 1. The container is (close) to full (the container full check already exists) 2. The volume is full EXCLUDING committed space (`reserved - available - min free <= 0`). This is because when a volume is full INCLUDING committed space (`reserved - available - committed - min free <= 0`), open containers can still accept writes. So the current behaviour of sending a close container action when volume is full including committed space is a bug. 3. The container is unhealthy (this is existing behaviour). We decided to not send volume reports in the immediate heartbeat and instead rely on regular node reports for that. This allows us to make the throttling per container. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org
